Fix columnize bug, where tab completion with very long filenames would crash Qt console #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug reported on-list.
… qt console. Any time tab completion was activated with a filename in the path longer than the width of the window, the console would crash.
|
Reviewed in detail on IRC channel, @minrk signs off on it so I'm merging it now. |
fperez
added a commit
that referenced
this pull request
Aug 17, 2011
Fix columnize bug, where tab completion with very long filenames would crash Qt console. Thanks to Mani Chandra for reporting on list and Julian Taylor for the script to reproduce the crash.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix columnize bug, where tab completion with very long filenames would crash Qt console. Thanks to Mani Chandra for reporting on list and Julian Taylor for the script to reproduce the crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on list: http://mail.scipy.org/pipermail/ipython-user/2011-August/008184.html
Thanks to Mani Chandra for the report and Julian for the script to reproduce the bug.